Nordfriese
Topic Opener
Joined: 2017-01-17, 18:07
Posts: 2021
OS: Debian Testing
Version: Latest master
One Elder of Players
Location: 0x55555d3a34c0
|
Posted at: 2020-10-23, 11:53
The voting result is pretty clear I'll remove the code for background testing and make design 1 permanent then
Top
Quote
|
|
|
the-x
Joined: 2019-01-19, 13:23
Posts: 967
One Elder of Players
|
Posted at: 2020-10-23, 12:04
I'm voting for 2 and 7, like the designs a lot
Top
Quote
|
|
|
niektory
Joined: 2019-06-03, 20:06
Posts: 206
Widelands-Forum-Junkie
Location: Poland
|
Posted at: 2020-10-23, 12:48
I'm a little late, but I'd prefer 7, 2 or 5.
Top
Quote
|
|
|
jmoerschbach
Joined: 2019-09-26, 21:40
Posts: 24
Pry about Widelands
|
Posted at: 2020-10-23, 13:28
Nordfriese wrote:
So you're already working on that? Great
The branch I have open currently (and which I hope will get merged sometime soon, it has some bug fixes in it) touches the layout only insofar that title_ is removed (as it is now replaced by the window title), and that FullscreenMenuBase and FullscreenWindow are also deleted (instead the windows now inherit directly from UI::Window ).
Oh ok, this of course will affect my branch but I will handle it...
Edited: 2020-10-23, 17:39
Top
Quote
|
|
|
GunChleoc
Joined: 2013-10-07, 15:56
Posts: 3317
One Elder of Players
Location: RenderedRect
|
Posted at: 2020-10-24, 08:32
The 1's still have it.
Busy indexing nil values
Top
Quote
|
|
|
Nordfriese
Topic Opener
Joined: 2017-01-17, 18:07
Posts: 2021
OS: Debian Testing
Version: Latest master
One Elder of Players
Location: 0x55555d3a34c0
|
Posted at: 2020-10-25, 21:01
jmoerschbach wrote:
Nordfriese wrote:
So you're already working on that? Great
The branch I have open currently (and which I hope will get merged sometime soon, it has some bug fixes in it) touches the layout only insofar that title_ is removed (as it is now replaced by the window title), and that FullscreenMenuBase and FullscreenWindow are also deleted (instead the windows now inherit directly from UI::Window ).
Oh ok, this of course will affect my branch but I will handle it...
Oh and I just remembered this: https://github.com/widelands/widelands/pull/4274#issuecomment-708242229
All these windows are going to become non-modal UI::UniqueWindow s. I will start with the next big branch for this conversion and the font update as soon as #4274 is merged. The main menu controller code will be moved from WLApplication to FsMenuMain but at least that part should have no merge conflicts with your work…
Top
Quote
|
|
|
GunChleoc
Joined: 2013-10-07, 15:56
Posts: 3317
One Elder of Players
Location: RenderedRect
|
Posted at: 2020-10-26, 10:07
The main menu controller code will be moved from WLApplication to FsMenuMain
+1
Busy indexing nil values
Top
Quote
|
|
|
Nordfriese
Topic Opener
Joined: 2017-01-17, 18:07
Posts: 2021
OS: Debian Testing
Version: Latest master
One Elder of Players
Location: 0x55555d3a34c0
|
Posted at: 2020-10-26, 15:10
The second part of the redesign is merged now. As I got started on the third part I noticed something that escaped me so far because I usually play without sound: There is an "intro" music piece and a "menu" music piece. If I understand correctly it used to be that the "intro" song was placed during the splashscreen and the "menu" song in the main menu. Now we are always playing the "menu" piece and the "intro" song is never heard. Should I
-
Keep it as it is, and remove the dead code for the "intro" song's special handling, or
-
Use "intro" while the splashscreen is visible and while the menu is fading in, and switch to "menu" when the menu is ready for use, or
-
Something else
?
Top
Quote
|
|
|
GunChleoc
Joined: 2013-10-07, 15:56
Posts: 3317
One Elder of Players
Location: RenderedRect
|
Posted at: 2020-10-26, 17:25
Originally, the intro played to the end if no key was pressed, then things continued on to the main menu. I never got to hear it much, since I always hit a key anyway...
Busy indexing nil values
Top
Quote
|
|
|
wurtison33
Joined: 2020-10-28, 15:53
Posts: 1
Just found this site
|
Posted at: 2020-10-28, 15:55
I'm a little late, but would prefer 7, 2. This design seems to be more convenient and understandable. I would vote also for the bluish buttons.
Edited: 2020-10-28, 15:59
Edited by kaputtnik: Removed external link
Top
Quote
|