Topic: New notifications
GunChleoc
Joined: 2013-10-07, 15:56
Posts: 3317  One Elder of Players Location: RenderedRect |
Posted at: 2017-06-08, 12:38
Me too. do let us know when you have a fix so I can switch it on again for testing. Busy indexing nil values 
Top
Quote
|
kaputtnik
Topic Opener
Joined: 2013-02-18, 20:48
Posts: 2550 OS: Archlinux Version: current master One Elder of Players Location: Germany |
Posted at: 2017-06-08, 18:25
Yes i have also those emails. My last of today was at 17:00 for Map Anchor. I will try to log some things now...
Top
Quote
|
|
kaputtnik
Topic Opener
Joined: 2013-02-18, 20:48
Posts: 2550 OS: Archlinux Version: current master One Elder of Players Location: Germany |
Posted at: 2017-06-08, 23:31
Ah, found it:
My guess is that some bots (and users as well) used the download links and trigger the notifications. So for old maps i guess the notifications are triggered from bots (who follow every link a website has). When testing at home and on the test site, nobody thought of that. I have changed the code now, so the notifications are send only if a new map is saved. Hopefully all is working now, sorry again for the spam. I uploaded a map for testing purpose which i will delete .... only have to wait 10 Minutes... Edited: 2017-06-08, 23:40
Top
Quote
|
WorldSavior
Joined: 2016-10-15, 04:10
Posts: 2125 OS: Linux Version: Recent tournament version One Elder of Players Location: Germany |
Posted at: 2017-06-08, 23:33
I downloaded "Anchor" today Wanted to save the world, then I got widetracked
Top
Quote
|
|
kaputtnik
Topic Opener
Joined: 2013-02-18, 20:48
Posts: 2550 OS: Archlinux Version: current master One Elder of Players Location: Germany |
Posted at: 2017-06-08, 23:42
Yes, see it positive: So some of you may downloaded maps which you had never downloaded if this failure doesn't happend
Top
Quote
|
|
WorldSavior
Joined: 2016-10-15, 04:10
Posts: 2125 OS: Linux Version: Recent tournament version One Elder of Players Location: Germany |
Posted at: 2017-06-09, 18:47
For me there is nothing negative, I didn't activate any notifications. It's just funny for me that I'm one of the "bots" Wanted to save the world, then I got widetracked
Top
Quote
|
Nordfriese
Joined: 2017-01-17, 18:07
Posts: 2056 OS: Debian Testing Version: Latest master One Elder of Players Location: 0x55555d3a34c0 |
Posted at: 2017-06-20, 14:54
@Kaputtnik: The notifications worked well since you said you fixed the problem, but now there was some strange behaviour: I just received a notification for the map Advetiset 9 that was uploaded several years ago. This is the first problem with the notifications since your last post…
Top
Quote
|
|
kaputtnik
Topic Opener
Joined: 2013-02-18, 20:48
Posts: 2550 OS: Archlinux Version: current master One Elder of Players Location: Germany |
Posted at: 2017-06-20, 17:33
Thanks for your info. I got this email too... damn Edit: I think it's the map voting function that is culprit. I look into it.... Edited: 2017-06-20, 18:07
Top
Quote
|
|
kaputtnik
Topic Opener
Joined: 2013-02-18, 20:48
Posts: 2550 OS: Archlinux Version: current master One Elder of Players Location: Germany |
Posted at: 2017-06-20, 22:09
A comment in the code stated save() is not needed when voting and i believed it without a deeper look. I have changed the statement to a more meaningfull one. Now there should be really no more useless emails Edited: 2017-06-20, 22:17
Top
Quote
|
