Topic: game scheduling module
trimard
Topic Opener
Joined: 2009-03-05, 22:40
Posts: 230  Widelands-Forum-Junkie Location: Paris |
Posted at: 2017-09-19, 23:34
Yes you're right. Definitely avaibilities makes no sense. I asked my english cousins and they agree with you guys. It's changed now 
Top
Quote
|
GunChleoc
Joined: 2013-10-07, 15:56
Posts: 3317  One Elder of Players Location: RenderedRect |
Posted at: 2017-09-21, 15:45
Rename the table to 'times_available'? We shouldn't have bad UI strings just because of what the code looks like internally. I think "availabilities" sounds very stilted. I would always ask "When will you be available?", never "When will you have any availabilities?" Edited: 2017-09-21, 15:46
Busy indexing nil values
Top
Quote
|
WorldSavior
Joined: 2016-10-15, 04:10
Posts: 2128 OS: Linux Version: Recent tournament version One Elder of Players Location: Germany |
Posted at: 2017-09-22, 16:27
But it's not impossible Wanted to save the world, then I got widetracked
Top
Quote
|
kaputtnik
Joined: 2013-02-18, 20:48
Posts: 2552 OS: Archlinux Version: current master One Elder of Players Location: Germany |
Posted at: 2017-09-22, 18:23
Just a question because i use also a datepicker for the search and used the jquery ui Datepicker. I am not sticked with that and want to prevent double code. So the question is: Is there a particular reason to use kalendae? If you think Kalendae works better for your approach, i wait until you branch get merged and will also use Kalendae
Top
Quote
|
|
trimard
Topic Opener
Joined: 2009-03-05, 22:40
Posts: 230 Widelands-Forum-Junkie Location: Paris |
Posted at: 2017-09-23, 00:07
It is pure JS. That's the initial reason I used it. I didn't know you had jquery before touching the responsive branch! Other than that? None. I guess it is pretty lightweight but I don't know how it compares with JqueryUI's datepicker. IIRC Jquery UI require to add a core file?
32 minutes compared to your... 14? Still a long way to go.
Good point, you clarified why the name felt weird: we don't use it that often! I'll make the change next week Edited: 2017-09-23, 00:09
Top
Quote
|
|
kaputtnik
Joined: 2013-02-18, 20:48
Posts: 2552 OS: Archlinux Version: current master One Elder of Players Location: Germany |
Posted at: 2017-09-23, 10:24
I do not understand what you mean with "adding a core file" Beside the datepicker Jquery ui comes also with some nice animations... i like that While working on this i found that the jquery served by us is somehow outdated. So i am working also on a branch that updates jquery and adjust our own javascript snippets and needed updates for other foreign js packages (mainly highcharts).
Top
Quote
|
|
trimard
Topic Opener
Joined: 2009-03-05, 22:40
Posts: 230 Widelands-Forum-Junkie Location: Paris |
Posted at: 2017-09-23, 13:09
A file for the datepicker and a file that is required for any jquery UI widget. But if that doesn't tell you anything it must mean it's not required
Ok, I'll addd in my branch to then! Or do you think I should wait you push your branch and go from there?
Yes I confirm! Good idea to change that !
Top
Quote
|
|
kaputtnik
Joined: 2013-02-18, 20:48
Posts: 2552 OS: Archlinux Version: current master One Elder of Players Location: Germany |
Posted at: 2017-09-23, 16:11
The datepicker is part of the jquery-ui library. I think some of the provided things could be useful for widelands.org.
Lets wait for merging the javascript update branch first. After that it should be equal. Be sure the jqueri-datepicker is as usefull for you as Kalendae.
Top
Quote
|
|
trimard
Topic Opener
Joined: 2009-03-05, 22:40
Posts: 230 Widelands-Forum-Junkie Location: Paris |
Posted at: 2017-09-25, 12:59
Yes, no problem, I checked there is a callback function "OnSelect" that will allow me to updates the date on user click. It's even simpler to use that kalandae apparently.
Need help for that one?
Top
Quote
|
|
kaputtnik
Joined: 2013-02-18, 20:48
Posts: 2552 OS: Archlinux Version: current master One Elder of Players Location: Germany |
Posted at: 2017-09-25, 14:40
Yes I am struggling with updating to fancybox version 3. Fancybox is used in the screenshots section. My implementation is working but needs a bit fine tuning, because it is not that nice as the current implementation... Mainly a border around the upscaled image and the position of the image description looks not good. For the border we have now white color but i think it would be nice to use an image for the border (like the wooden background of the menu) . Don't know if this would be feasible.
Top
Quote
|
