Topic: "Northmen" Tribe Page

Forums » Player Forums » Technical Help » "Northmen" Tribe Page
hessenfarmer
Avatar
Joined: 2014-12-11, 22:16
Posts: 2797
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2018-04-20, 21:05

Sorry for quoting this quite old post. But from a "feature" of transifex discovered lately it came to me there might be a wrong string in the frisians:

Nordfriese wrote:

The soldiers are called warriors. Their max training is: attack 6, health 4, evade 0, defense 0.

currently they are not called warriors but soldiers, as warriors would fit better to the character of the tribe as already decided for the german translation this should probably reflected in the source files as well.

Top Quote
Nordfriese
Avatar
Topic Opener
Joined: 2017-01-17, 17:07
Posts: 2112
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2018-04-20, 21:55

hessenfarmer wrote:

Nordfriese wrote:

The soldiers are called warriors. Their max training is: attack 6, health 4, evade 0, defense 0.

currently they are not called warriors but soldiers, as warriors would fit better to the character of the tribe as already decided for the german translation this should probably reflected in the source files as well.

I originally called them "warriors", then changed it to "soldiers" for consistency with the other tribes. But I agree "warriors" would fit better. Should I change the name?
(Which breaks all existing savegames with frisians again btw)

Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 22:16
Posts: 2797
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2018-04-20, 22:03

I would vote for that to give the translators in other languages as well the chance to distinguish warriors from soldiers. Another observation from the translation is it seems there is no scout for the frisians. Maybe in the lua there are some underscores missing.

Edited: 2018-04-20, 22:06
Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 14:56
Posts: 3317
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2018-04-21, 07:58

Please leave it as "Soldiers", because we still have "Soldiers" hard-coded into some stuff. I will resolve this issue by programming for Build 21

https://bugs.launchpad.net/widelands/+bug/1765335

Busy indexing nil values

Top Quote
GunChleoc
Avatar
Joined: 2013-10-07, 14:56
Posts: 3317
Ranking
One Elder of Players
Location: RenderedRect
Posted at: 2018-04-21, 08:00

Found the scout problem:

pgettext ("frisians_worker", "Scout"),

the extra blank space before ( is preventing xgettext from finding the string.

https://bugs.launchpad.net/widelands/+bug/1765918

Good catch! face-smile.png

Edited: 2018-04-21, 08:02

Busy indexing nil values

Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 22:16
Posts: 2797
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2018-04-21, 15:22

GunChleoc wrote:

Good catch! face-smile.png

Merits for this need to go to Venatrix. I have not checked whether there are other strings not catched

Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 22:16
Posts: 2797
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2018-04-21, 15:25

GunChleoc wrote:

Please leave it as "Soldiers", because we still have "Soldiers" hard-coded into some stuff. I will resolve this issue by programming for Build 21

https://bugs.launchpad.net/widelands/+bug/1765335

May I ask which parts are hardcoded?

Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 22:16
Posts: 2797
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2018-04-21, 15:33

GunChleoc wrote:

Found the scout problem:

~~~~ pgettext ("frisians_worker", "Scout"), ~~~~

Actually I just read the Mail with the question from Venatrix on transifex. Therefore Iwas mislead about the nature of the problem. There is no Problem with the scout not fetched. Sorry for bothering everyone.
the real problem was in the description of the tavern as it misses the fact that a scout needs rations as well. so probably the description text of the frisians needs a small update.

Top Quote
Nordfriese
Avatar
Topic Opener
Joined: 2017-01-17, 17:07
Posts: 2112
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2018-04-21, 15:51

hessenfarmer wrote:

the real problem was in the description of the tavern as it misses the fact that a scout needs rations as well. so probably the description text of the frisians needs a small update.

The tavern helptext says "Prepares rations to feed the scouts and miners.". Do you mean the purpose helptext for the drinking hall? The scout reference is missing there, I´ll add it…

Top Quote
hessenfarmer
Avatar
Joined: 2014-12-11, 22:16
Posts: 2797
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2018-04-21, 15:57

yes it was the drinking_hall helptext. sorry for the confusion.

Top Quote