Topic: Use std::algorithm when possible?

cppcheck reports a lot issues of the type "Consider using std::count_if algorithm instead of a raw loop." but I am not sure, whether we want this.

So for example

uint32_t cnt = 0;
for (auto item : queue) {
    if (item.second == additional_id) {
        ++cnt;
    }
}
return cnt;

would become something like this:

return std::count_if(
   queue.begin(), queue.end(), [additional_id](const std::pair<uint32_t, uint32_t>& item) {
       return item.second == additional_id;
   });

Do we want to use this style, or leave it as it is?

Top

Quote

GunChleoc wrote:

Would it work like this?

Nope:

ai_help_structs.cc:307:56: error: 'auto' not allowed in lambda parameter

I agree with you, that the current style is more readable. Lambdas are fancy, but sometimes hard to read / understand.

Top

Quote

I don't think a GitHub action is a good idea. Creating such a report takes a long time (~30min). Additionally it reports false positives (see examples below) or hints only, which would be difficult to handle in an automatic workflow. To use it simply to detect const issues is not worth it in my opinion.

There is also a list of unused functions, but hesitated removing them straight away, because they might be intended for future use.

Some examples:

src/io/machdep.h:62: (error) Uninitialized variable: s => it is iniatialized

src/economy/ship_fleet.cc:212: (warning) Non-pure function: 'get_schedule' is called inside assert statement. Assert statements are removed from release builds so the code inside assert statement is not executed. If the code is needed also in release builds, this is a bug. => can be a bug, or was intended

src/logic/map_objects/tribes/requirements.h:82: (style) Struct 'Requirements' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided. => explicit and templates don’t work together

Top

Quote