Topic: Release 1.2

Forums » Widelands Development » Coding & Scripting » Release 1.2
hessenfarmer
Avatar
Joined: 2014-12-11, 23:16 UTC+1.0
Posts: 2821
Ranking
One Elder of Players
Location: Bavaria
Posted at: 2024-11-02, 10:21 UTC+1.0

tothxa wrote:

hessenfarmer wrote:

we have a reproducable bug in the windows 32 bit version that is really annoying.

Is this new to 1.2.1rc1, or also affects v1.2?

I could not test yet. Will be able to do that on sunday at the earliest.

Top Quote
tothxa
Avatar
Joined: 2021-03-24, 12:44 UTC+1.0
Posts: 517
OS: antix / Debian
Version: some new PR I'm testing
Ranking
One Elder of Players
 Posted at: 2024-11-02, 15:28 UTC+1.0

hessenfarmer wrote:

getting a backtrace was not possible as the crash of the game was catched by our framework, which provided a error message.
or at least I do not know how to get a backtrace in this case with gdb.

Since you know the place of the problem, you should be able to set a breakpoint, and print the backtrace when the breakpoint is hit. Should be something like this (at least this works on linux):

break map.cc:2191
Top Quote
Nordfriese
Avatar
Topic Opener
Joined: 2017-01-17, 18:07 UTC+1.0
Posts: 2128
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2024-11-07, 09:57 UTC+1.0

We will not go to release today… face-sad.png

I found a reproducible desync in 1.2.1. To trigger, start a two-player LAN game on Fellowships with naval warfare enabled, no fog of war, and both starting positions set to Barbarians-Discovery, third player slot closed. It happens around gametime 1574 milliseconds. Am investigating, and when I find out how to fix, IMO we'd better have a second release candidate to be safe.

Top Quote
Nordfriese
Avatar
Topic Opener
Joined: 2017-01-17, 18:07 UTC+1.0
Posts: 2128
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2024-11-07, 10:33 UTC+1.0

Fix is up: https://codeberg.org/wl/widelands/pulls/4926

Edited: 2024-11-07, 12:15 UTC+1.0
Top Quote
Nordfriese
Avatar
Topic Opener
Joined: 2017-01-17, 18:07 UTC+1.0
Posts: 2128
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2024-11-10, 10:20 UTC+1.0

The second release candidate is out!

https://codeberg.org/wl/widelands/releases/tag/v1.2.1-rc2

I'm planning the final point release for next Friday, the 15th of November, 2024.

Please report any major bugs you find with the point release.

Top Quote
kaputtnik
Avatar
Joined: 2013-02-18, 20:48 UTC+1.0
Posts: 2654
OS: Archlinux
Version: current master
Ranking
One Elder of Players
Location: Germany
Posted at: 2024-11-10, 17:51 UTC+1.0

Played a naval ware fare game today with the rc2 candidate.

  • Really no showstopper: I like to watch where one of my heroes goes. So i try to catch him in a watch window. As far i remember if he is on a ship the watch window follows this ship in v1.2. In this game the watch windows stayed at the port where he was going onboard and switched to the position where he left the ship again.
  • After attacking a port space and conquering some foreign military buildings (they burned) the game suddenly stuck at 0,1 speed. Very slow motion. After some time the speed get back to 2x. I tried to reproduce by loading the last save game, but then all ran smooth.
Top Quote
Nordfriese
Avatar
Topic Opener
Joined: 2017-01-17, 18:07 UTC+1.0
Posts: 2128
OS: Debian Testing
Version: Latest master
Ranking
One Elder of Players
Location: 0x55555d3a34c0
Posted at: 2024-11-10, 20:08 UTC+1.0

kaputtnik wrote:

  • Really no showstopper: I like to watch where one of my heroes goes. So i try to catch him in a watch window. As far i remember if he is on a ship the watch window follows this ship in v1.2. In this game the watch windows stayed at the port where he was going onboard and switched to the position where he left the ship again.

That behaviour is also in v1.2 and has been around forever. Worker positions are not updated while they are being shipped.

  • After attacking a port space and conquering some foreign military buildings (they burned) the game suddenly stuck at 0,1 speed. Very slow motion. After some time the speed get back to 2x. I tried to reproduce by loading the last save game, but then all ran smooth.

Do you have a replay? The most likely cause is having very many invasion soldiers in a very cramped space, which slows the game a lot because each one keeps trying to go closer to the destination but soldiers on an invasion are not allowed to walk across each other, so they keep blocking each other's way.

Top Quote
kaputtnik
Avatar
Joined: 2013-02-18, 20:48 UTC+1.0
Posts: 2654
OS: Archlinux
Version: current master
Ranking
One Elder of Players
Location: Germany
Posted at: 2024-11-10, 20:43 UTC+1.0

Nordfriese wrote:

kaputtnik wrote:

  • Really no showstopper: I like to watch where one of my heroes goes. So i try to catch him in a watch window. As far i remember if he is on a ship the watch window follows this ship in v1.2. In this game the watch windows stayed at the port where he was going onboard and switched to the position where he left the ship again.

That behaviour is also in v1.2 and has been around forever. Worker positions are not updated while they are being shipped.

I am not sure... i remember that the watch window followed the soldier on ships.

  • After attacking a port space and conquering some foreign military buildings (they burned) the game suddenly stuck at 0,1 speed. Very slow motion. After some time the speed get back to 2x. I tried to reproduce by loading the last save game, but then all ran smooth.

Do you have a replay? The most likely cause is having very many invasion soldiers in a very cramped space, which slows the game a lot because each one keeps trying to go closer to the destination but soldiers on an invasion are not allowed to walk across each other, so they keep blocking each other's way.

See attachment. The attack starts round about 2:06:50 game time against the red players port. The slow down is also in the replay.

Attachment: application/zip
2024-11-10T16.44.36_single_player.wry.zip (510.2 KB)
Top Quote
tothxa
Avatar
Joined: 2021-03-24, 12:44 UTC+1.0
Posts: 517
OS: antix / Debian
Version: some new PR I'm testing
Ranking
One Elder of Players
 Posted at: 2024-11-11, 11:03 UTC+1.0

RC2 is up on flathub-beta too.

Top Quote