Topic: Travis codechecking misbehaviour

11 — 15 of 15 Posts ‹‹ previous 1 2

Nordfriese Topic Opener Joined: 2017-01-17, 18:07 Posts: 2057 OS: Debian Testing Version: Latest master One Elder of Players Location: 0x55555d3a34c0	Posted at: 2020-01-31, 22:14 The formatting workflow is functional now. It will automatically format the master branch (untested of course) and any branch with an open pull request. In the latter case it seems to fail very verbosely with a number of error message (due to the workflow being in my fork but not in the base repo) - even though all is working fine in the background. This leads to a wonderful chicken-and-egg problem: I would like to fix all the error messages before merging it to master, and the messages won´t disappear as long as it is not in master... Edited: 2020-01-31, 22:32 Top Quote

hessenfarmer Joined: 2014-12-11, 23:16 Posts: 2745 One Elder of Players Location: Bavaria	Posted at: 2020-01-31, 23:01 Nordfriese wrote: The formatting workflow is functional now. It will automatically format the master branch (untested of course) and any branch with an open pull request. In the latter case it seems to fail very verbosely with a number of error message (due to the workflow being in my fork but not in the base repo) - even though all is working fine in the background. This leads to a wonderful chicken-and-egg problem: I would like to fix all the error messages before merging it to master, and the messages won´t disappear as long as it is not in master... basically I would vote for giving it a try in master in a predefined period announced here and in github. where we only make pushes to test this for which we know how to revert things. EDIT: Forgot to say thank you for taking care of this. Edited: 2020-01-31, 23:01 Top Quote

Nordfriese Topic Opener Joined: 2017-01-17, 18:07 Posts: 2057 OS: Debian Testing Version: Latest master One Elder of Players Location: 0x55555d3a34c0	Posted at: 2020-01-31, 23:08 I think I found the real reason for the errors ...: Are 3rd party actions allowed in the widelands/widelands repo settings? I believe they aren´t, and enabling them should fix everything. @stonerl/Gunchleoc could one of the admins check this setting? (I don´t have permission even to view it) Top Quote

Nordfriese Topic Opener Joined: 2017-01-17, 18:07 Posts: 2057 OS: Debian Testing Version: Latest master One Elder of Players Location: 0x55555d3a34c0	Posted at: 2020-02-02, 00:29 Pull request is ready for review https://github.com/widelands/widelands/pull/3664 Please note the additional information in the description Top Quote

GunChleoc Joined: 2013-10-07, 15:56 Posts: 3317 One Elder of Players Location: RenderedRect	Posted at: 2020-02-07, 10:44 Let me take care of the merging - I can run `utils/merge_and_push_translations.sh` to get a push to master that we can afford to lose. Edited: 2020-02-07, 10:44 Busy indexing nil values Top Quote

‹‹ previous 1 2